Snowy Evening

Ok. The following works... instead of a new class, I simply changed the initialize() in PrismBlockEditSessionFactory to the following. Notice that I have temporarily commented out the old initialization, as it would only be applicable for WorldEdit < 6.0. The register(new Object(... will have to be conditional on WorlEdit > 6.0 also, but I haven't done that yet. I had to change the type of onBlockChange from void to BaseBlock and imlement an oldBlock parameter in WorldEdit's AbstractLoggingExtent because the override was giving me trouble with nothing to return, and we need the oldBlock for the Prism database record. The only real remaining issue is that three records are being created for each change. This is probably because the event is being fired for each of the three stages BEFORE_HISTORY, BEFORE_REORDER, and BEFORE_CHANGE. I am not sure how to just select one in this approach, and having the extra records doesn't really affect the rollbacks. Anyone that knows how to select just one can let me know. I tested the rollbacks after doing WE changes and they work!!

file PrismBlockEditSessionFactory.java

package me.botsko.prism.bridge;

...various imports...

...older Factory methods...

public class PrismBlockEditSessionFactory extends EditSessionFactory {

public static void initialize() {
    try {
        // Check to see if the world edit version is compatible
        // Class.forName( "com.sk89q.worldedit.EditSessionFactory" ).getDeclaredMethod( "getEditSession",
        // World.class, int.class, BlockBag.class, Player.class );
        // WorldEdit.getInstance().setEditSessionFactory( new PrismBlockEditSessionFactory() );
        WorldEdit.getInstance().getEventBus().register(new Object() {
            @Subscribe
            public void wrapForLogging(EditSessionEvent event) {
                final Actor player = event.getActor();
                event.setExtent(new AbstractLoggingExtent(event.getExtent()) {
                    @Override
                    protected BaseBlock onBlockChange(Vector position, BaseBlock oldBlock, BaseBlock newBlock) {
                        if( !( ((Player) player).getWorld() instanceof BukkitWorld ) || !Prism.config.getBoolean( "prism.tracking.world-edit" )
                                ) { return super.onBlockChange(position, oldBlock, newBlock); }
                        final Location loc = new Location( Bukkit.getWorld( ((Player) player).getWorld().getName() ), position.getBlockX(),
                                position.getBlockY(), position.getBlockZ() );
                        RecordingQueue.addToQueue( ActionFactory.createBlockChange("world-edit", loc, oldBlock.getId(),
                                (byte) oldBlock.getData(), newBlock.getId(), (byte) newBlock.getData(), player.getName()) );
                        return super.onBlockChange(position, oldBlock, newBlock);
                    }
                });
            }
        });
    } catch ( final Throwable ignored ) {
    }

}

file AbstractLoggingExtent.java

package com.sk89q.worldedit.extent.logging;

public abstract class AbstractLoggingExtent extends AbstractDelegateExtent {

/**
 * Create a new instance.
 *
 * @param extent the extent
 */
protected AbstractLoggingExtent(Extent extent) {
    super(extent);
}
/**
 * Called when a block is being changed.
 *
 * @param position the position
 * @param newBlock the new block to replace the old one
 */
protected BaseBlock onBlockChange(Vector position, BaseBlock oldBlock, BaseBlock newBlock) {
    return newBlock;
}
@Override
public final boolean setBlock(Vector position, BaseBlock block) throws WorldEditException {
    BaseBlock oldBlock = getBlock(position);
    onBlockChange(position, oldBlock, block);
    return super.setBlock(position, block);
}

}

Ok. I have solved the multiple row logging problem by checking the value of getStage() on the event, and only registering for BEFORE_CHANGE. I have attached the two files in their current form from Prism and WorldEdit 6.0 (latest). The logging appears to be working correctly now.

It may be better to move the initialization code out of PrismBlockEditSessionFactory altogether and deprecate it, because the EditSessionFactory is not really being used anymore. We could create a class of a different name and change the checkPluginDependencies() in Prism.java to refer to the new class.

Anyone have any comments?

• PrismBlockEditSessionFactory.java
• AbstractLoggingExtent.java

Jamescowens, do you think that your code would work on the most recent dev builds of WorldEdit and Prism? I'm getting errors when I try to compile the latest dev build of Prism with your modified .java file, but that might just be an issue on my end with dependencies and such. My IDE is complaining about prismBlockEditSession() and onBlockChange(), inside of PrismBlockEditSessionFactory.java. I've only just recently started with plugin development, and so troubleshooting has been quite difficult. Do you have any advice, or would you perhaps be willing to supply a compiled .jar of WorldEdit and Prism? Thanks, by the way, for the time that you put into your writeup of the issue.

For anyone else reading, I'd like to confirm that this bug does indeed exist in the most recent dev build of Prism, build #31 of Prism 2.0.6, when used with the most recent dev build of WorldEdit 6.0. Here is some more detailed version information. This error now occurs on startup, giving information about why WorldEdit logging ceases to function, along with a message to contact the plugin's maintainer.

Hmm, my hyperlinks don't seem to be working. Here is my detailed version information:

>prism version
[05:04:47 INFO]: Prism // Prism - By viveleroi v2.0.6-31
[05:04:47 INFO]: Prism // Help: /pr ?
[05:04:47 INFO]: Prism // IRC: irc.esper.net #prism
[05:04:47 INFO]: Prism // Wiki: http://discover-prism.com
>we version
[05:04:55 INFO]: WorldEdit version (unknown)
[05:04:55 INFO]: https://github.com/sk89q/worldedit/
[05:04:55 INFO]: ----------- Platforms -----------
[05:04:55 INFO]: * Bukkit-Official (6.0.2-SNAPSHOT;3370-58aac973)
[05:04:55 INFO]: ----------- Capabilities -----------
[05:04:55 INFO]: GAME_HOOKS: Bukkit-Official
[05:04:55 INFO]: CONFIGURATION: Bukkit-Official
[05:04:55 INFO]: USER_COMMANDS: Bukkit-Official
[05:04:55 INFO]: PERMISSIONS: Bukkit-Official
[05:04:55 INFO]: WORLDEDIT_CUI: Bukkit-Official
[05:04:55 INFO]: WORLD_EDITING: Bukkit-Official

And here is the error that now occurs on startup:

[04:52:14 ERROR]: [WorldEdit] Got request to set EditSessionFactory of type me.botsko.prism.bridge.PrismBlockEditSessionFactor
y from me.botsko.prism.bridge but EditSessionFactories have been removed in favor of extending EditSession's extents.
 This may mean that any block logger / intercepters addons/plugins/mods that you have installed will not intercept WorldEdit's 
changes! Please notify the maintainer of the other addon about this.